New environment variable CARDANO_NODE_NETWORK_ID #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
changed the title
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/new-environment-variable-CARDANO_NODE_NETWORK_ID
branch
4 times, most recently
from
8994693 to
57720a6
Compare
newhoggy
changed the title
carbolymer
reviewed
Apr 18, 2023
newhoggy
force-pushed
the
newhoggy/new-environment-variable-CARDANO_NODE_NETWORK_ID
branch
2 times, most recently
from
ba45ca0 to
5a5632a
Compare
…vironment if it exists
…ment variable CARDANO_NODE_NETWORK_ID
newhoggy
force-pushed
the
newhoggy/new-environment-variable-CARDANO_NODE_NETWORK_ID
branch
from
5a5632a to
02567de
Compare
carbolymer
approved these changes
Apr 19, 2023
Jimbo4350
reviewed
Apr 24, 2023
| @@ -1169,7 +1169,7 @@ runTxCalculateMinFee (File txbodyFilePath) nw pParamsFile | |||
| let txbody = getTxBody unwitTx | |||
| let tx = makeSignedTransaction [] txbody | |||
| Lovelace fee = estimateTransactionFee | |||
| (fromMaybe Mainnet nw) | |||
| nw | |||
Jimbo4350
approved these changes
Apr 25, 2023
iohk-bors
bot
deleted the
newhoggy/new-environment-variable-CARDANO_NODE_NETWORK_ID
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARDANO_NODE_SOCKET_PATHenvironment variable is now recognised by every command that took a--testnet-magicCLI argument.Can now be written as: