Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify golden test functions to automatically create parent directories #5136

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Modify golden test functions to automatically create parent directories #5136

merged 1 commit into from
Apr 25, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Apr 21, 2023 •
edited
Loading

Description

This is useful for when writing new golden tests. Generating golden files from tests is easier if the directories are automatically created for you.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • Code is linted with hlint. See .github/workflows/check-hlint.yml for to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml for to get the stylish-haskell version
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review April 21, 2023 01:58
@newhoggy newhoggy force-pushed the newhoggy/modify-golden-test-functions-to-automatically-create-parent-directories branch from 03ebeae to e2a83ae Compare April 21, 2023 02:01
@newhoggy newhoggy added this pull request to the merge queue Apr 25, 2023
Merged via the queue into master with commit 03331ec Apr 25, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/modify-golden-test-functions-to-automatically-create-parent-directories branch April 25, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @carbolymer @Jimbo4350