Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHaP to get latest ledger with performance fix #5157

Merged
merged 4 commits into from
Apr 30, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Apr 26, 2023

Description

Nothing more, nothing less, just updating CHaP.

This PR now also switches all packages in the repo to use the latest consensus and network layers.

This is needed to get last released ledger that has some performance fixes.

Integrates latest network-mux and io-classes

Uses the new Consensus package structure.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@lehins lehins force-pushed the lehins/use-newer-ledger-with-performance-improvements branch 3 times, most recently from 7557d52 to 4be494a Compare April 28, 2023 12:47
@lehins lehins disabled auto-merge April 29, 2023 10:07
@disassembler disassembler force-pushed the lehins/use-newer-ledger-with-performance-improvements branch from 4be494a to 76cec07 Compare April 29, 2023 10:34
@disassembler disassembler added this pull request to the merge queue Apr 29, 2023
@disassembler disassembler removed this pull request from the merge queue due to a manual request Apr 29, 2023
@lehins lehins force-pushed the lehins/use-newer-ledger-with-performance-improvements branch from 76cec07 to 1ba916e Compare April 29, 2023 22:08
@lehins lehins force-pushed the lehins/use-newer-ledger-with-performance-improvements branch from 1ba916e to 23ce3f9 Compare April 29, 2023 22:17
@deepfire deepfire enabled auto-merge April 29, 2023 22:21
@lehins lehins disabled auto-merge April 30, 2023 00:30
lehins added 2 commits April 30, 2023 03:55
* Consensus has experience a major package consolidation.
  `ouroboros-consensus-byron`, `ouroboros-consensus-shelley` and
  `ouroboros-consensus-cardano-tools` have been subsumed by
  `ouroboros-consensus-cardano`

* Network experienced a new release that uses new 1.1 version of
  `io-sim` and `io-classes`
@lehins lehins force-pushed the lehins/use-newer-ledger-with-performance-improvements branch from 827369e to 8aa4e3c Compare April 30, 2023 02:11
@lehins lehins enabled auto-merge April 30, 2023 02:14
@lehins lehins added this pull request to the merge queue Apr 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 30, 2023
@lehins lehins added this pull request to the merge queue Apr 30, 2023
Merged via the queue into master with commit 1f9acd6 Apr 30, 2023
@iohk-bors iohk-bors bot deleted the lehins/use-newer-ledger-with-performance-improvements branch April 30, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants