Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--out-file option for governance commands #5172

Merged
merged 4 commits into from
May 1, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Apr 28, 2023

Description

Add --out-file option. Add some more golden tests, and test the boundaries to ensure based 0 numbering.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Newhoggy/out file option for governance commands --out-file option for governance commands Apr 28, 2023
@newhoggy newhoggy force-pushed the newhoggy/out-file-option-for-governance-commands branch from b13935e to 70dc73b Compare April 29, 2023 01:25
@newhoggy newhoggy marked this pull request as ready for review April 29, 2023 01:25
@newhoggy
Copy link
Contributor Author

@KtorZ

@newhoggy newhoggy force-pushed the newhoggy/out-file-option-for-governance-commands branch from 70dc73b to 44c4b76 Compare May 1, 2023 13:26
@newhoggy newhoggy added this pull request to the merge queue May 1, 2023
Merged via the queue into master with commit e1cefd9 May 1, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/out-file-option-for-governance-commands branch May 1, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants