Delete readEnvSocketPath function

[newhoggy]

Description

Delete readEnvSocketPath function pass in the SocketPath as argument explicitly instead.

This remnant code was causing CARDANO_NODE_SOCKET_PATH to be mandatory for a small number of commands.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • roundtrip tests
  • integration tests
    See Runnings tests for more details
• Any changes are noted in the CHANGELOG.md for affected package
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

[Jimbo4350]

LGTM!

[catch-21]

@newhoggy Is it also possible to do for constructBalancedTx?

[mkoura]

Closes #5199

[newhoggy]

constructBalancedTx is a pure function so I'm assuming it doesn't do any IO like reading an environment variable.

[catch-21]

You're right. It was queryStateForBalancedTx that was affected, so thanks for doing this!