Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden test for cardano-testnet help #5254

Merged
merged 3 commits into from
May 20, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 18, 2023

Description

We care about the help usage of the cardano-testnet as well, for example: #5234, so it's good to have golden tests for them.

Depends on #5206

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/add-golden-test-for-cardano-testnet-help branch 3 times, most recently from c975a26 to 483855e Compare May 18, 2023 04:13
@newhoggy newhoggy marked this pull request as ready for review May 18, 2023 04:25
@newhoggy newhoggy changed the title Add golden test for cardano testnet help Add golden test for cardano-testnet help May 18, 2023
@newhoggy newhoggy force-pushed the newhoggy/add-golden-test-for-cardano-testnet-help branch from 483855e to 9591a33 Compare May 18, 2023 06:40
, cardano-api ^>= 8.1.0.1
, cardano-api-gen ^>= 8.1.0.2
, cardano-cli
, cardano-cli:test-lib
Copy link
Contributor

@carbolymer carbolymer May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should bump cabal-version when we're using newer cabal features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature was introduced in cabal 3.0 and many other projects that this feature are still on cabal-version: 3.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cabal.readthedocs.io/en/stable/cabal-package.html#library

For packages using cabal-version: 3.4 or higher, the syntax to specify an internal library in a build-depends: section is package-name:internal-library-name.

@newhoggy newhoggy force-pushed the newhoggy/add-golden-test-for-cardano-testnet-help branch 7 times, most recently from aa6d28e to 697f944 Compare May 19, 2023 14:03
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@@ -1,5 +0,0 @@
Invalid argument `COMMAND'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has been modified to not generate this file.

@newhoggy newhoggy force-pushed the newhoggy/add-golden-test-for-cardano-testnet-help branch from 697f944 to 9375c90 Compare May 19, 2023 23:14
@newhoggy newhoggy enabled auto-merge May 20, 2023 02:19
@newhoggy newhoggy added this pull request to the merge queue May 20, 2023
Merged via the queue into master with commit 11fccd1 May 20, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/add-golden-test-for-cardano-testnet-help branch May 20, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants