-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golden test for cardano-testnet
help
#5254
Add golden test for cardano-testnet
help
#5254
Conversation
c975a26
to
483855e
Compare
cardano-testnet
help
483855e
to
9591a33
Compare
cardano-cli/cardano-cli.cabal
Outdated
, cardano-api ^>= 8.1.0.1 | ||
, cardano-api-gen ^>= 8.1.0.2 | ||
, cardano-cli | ||
, cardano-cli:test-lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should bump cabal-version
when we're using newer cabal features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature was introduced in cabal 3.0
and many other projects that this feature are still on cabal-version: 3.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cabal.readthedocs.io/en/stable/cabal-package.html#library
For packages using cabal-version: 3.4 or higher, the syntax to specify an internal library in a build-depends: section is package-name:internal-library-name.
aa6d28e
to
697f944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
@@ -1,5 +0,0 @@ | |||
Invalid argument `COMMAND' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code has been modified to not generate this file.
697f944
to
9375c90
Compare
Description
We care about the help usage of the
cardano-testnet
as well, for example: #5234, so it's good to have golden tests for them.Depends on #5206
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.