Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cryptoInit instead of sodiumInit #5291

Merged
merged 1 commit into from
May 31, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 31, 2023

Description

Add the call to cryptoInit to various components including tests where they haven't been previously.

See IntersectMBO/cardano-base#175

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review May 31, 2023 12:07
@newhoggy newhoggy force-pushed the newhoggy/use-cryptoInit-instead branch from 8577195 to 4856447 Compare May 31, 2023 12:43
@newhoggy newhoggy force-pushed the newhoggy/use-cryptoInit-instead branch from 4856447 to 6d044a0 Compare May 31, 2023 13:17
@newhoggy newhoggy force-pushed the newhoggy/use-cryptoInit-instead branch from 6d044a0 to 0c544c2 Compare May 31, 2023 13:24
@newhoggy newhoggy enabled auto-merge May 31, 2023 13:52
@newhoggy newhoggy disabled auto-merge May 31, 2023 13:52
@newhoggy newhoggy added this pull request to the merge queue May 31, 2023
Merged via the queue into master with commit aba117f May 31, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/use-cryptoInit-instead branch May 31, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants