Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate --testnet-magic flag #5309

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 9, 2023

Description

The duplicate flag meant that the flag needed to be specified twice.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/remove-duplicate-testnet-magic-flag branch from 35074d2 to 42f044f Compare June 9, 2023 04:42
@newhoggy newhoggy requested review from Jimbo4350 and carbolymer June 9, 2023 04:42
@newhoggy newhoggy marked this pull request as ready for review June 9, 2023 04:44
@newhoggy newhoggy force-pushed the newhoggy/remove-duplicate-testnet-magic-flag branch from 42f044f to 5e73482 Compare June 9, 2023 04:46
@newhoggy newhoggy force-pushed the newhoggy/remove-duplicate-testnet-magic-flag branch from 5e73482 to 64fc35e Compare June 9, 2023 04:50
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this must have snuck in after my rebasing.

@newhoggy newhoggy added this pull request to the merge queue Jun 14, 2023
Merged via the queue into master with commit 9e6da6e Jun 14, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/remove-duplicate-testnet-magic-flag branch June 14, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants