Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retry tests with DISABLE_RETRIES=1 #5340

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 18, 2023

Description

Some tests will retry a number of times before failing proper. When testing locally, it may be undesirable to have the test retry. By defining this environment variable DISABLE_RETRIES=1 , the test will not retry.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review June 18, 2023 05:56
@newhoggy newhoggy force-pushed the newhoggy/can-disable-test-retries-with-DISABLE_RETRIES=1 branch from 235891a to aa71b68 Compare June 19, 2023 22:22
@newhoggy newhoggy enabled auto-merge June 19, 2023 22:22
@newhoggy newhoggy added this pull request to the merge queue Jun 19, 2023
Merged via the queue into master with commit 7bf09ba Jun 19, 2023
16 of 24 checks passed
@iohk-bors iohk-bors bot deleted the newhoggy/can-disable-test-retries-with-DISABLE_RETRIES=1 branch June 19, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants