Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plutus script costing in cardano-testnet #5400

Merged

Conversation

catch-21
Copy link
Contributor

@catch-21 catch-21 commented Jul 19, 2023

Description

Recent changes in 313bd58 has caused the the plutus script execution budgets and fee calculation to be wildly unrealistic. E.g. fee is far too high on larger scripts (like 50ada). This PR addresses:

  • The bug where execution prices for cpu and mem were mixed up
  • The max tx and block execution units are now the same as mainnet's onchain parameters
  • The PlutusV1 cost model is now the same as mainnet's onchain parameters

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@catch-21 catch-21 requested a review from a team as a code owner July 19, 2023 08:34
@Jimbo4350 Jimbo4350 self-requested a review July 19, 2023 13:56
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jul 19, 2023
Merged via the queue into IntersectMBO:master with commit 537bc33 Jul 19, 2023
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants