Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stubbed LogFormatting instances #5412

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 24, 2023

Description

Fix stubbed LogFormatting instances after integration of Conway changes.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-stubbed-logformatting-instances-from-conway branch 4 times, most recently from ec327a4 to a264eb2 Compare July 25, 2023 12:54
@carbolymer carbolymer marked this pull request as ready for review July 25, 2023 13:44
@carbolymer carbolymer requested a review from a team as a code owner July 25, 2023 13:44
@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-stubbed-logformatting-instances-from-conway branch from a264eb2 to 8eb257c Compare July 25, 2023 13:46
@carbolymer carbolymer requested review from Jimbo4350 and newhoggy July 25, 2023 13:46
@carbolymer carbolymer enabled auto-merge July 25, 2023 14:32
@jutaro
Copy link
Contributor

jutaro commented Jul 25, 2023

Oh I see, it all is about new tracing. That makes sense to me.

@carbolymer carbolymer disabled auto-merge July 25, 2023 14:33
@carbolymer carbolymer enabled auto-merge July 25, 2023 14:56
@carbolymer carbolymer disabled auto-merge July 25, 2023 14:56
@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-stubbed-logformatting-instances-from-conway branch from 8eb257c to 496a95e Compare July 26, 2023 13:12
@carbolymer carbolymer force-pushed the mgalazyn/fix/fix-stubbed-logformatting-instances-from-conway branch from 496a95e to 9806821 Compare July 26, 2023 13:13
@carbolymer carbolymer enabled auto-merge July 26, 2023 13:18
@carbolymer carbolymer added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit 34eb664 Jul 26, 2023
@iohk-bors iohk-bors bot deleted the mgalazyn/fix/fix-stubbed-logformatting-instances-from-conway branch July 26, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants