Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-git-rev: New version for CHaP #5430

Merged
merged 1 commit into from
Aug 8, 2023
Merged

cardano-git-rev: New version for CHaP #5430

merged 1 commit into from
Aug 8, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 7, 2023

Description

New version for CHaP.

The version currently in CHaP has an overly restrictlve base bound.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@erikd erikd enabled auto-merge August 7, 2023 11:00
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

* Version currently in CHaP has too restrictive a `base` bounds.
* Also update Nix stuff.
@erikd erikd added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit 892b620 Aug 8, 2023
27 of 29 checks passed
@erikd erikd deleted the erikd/chap branch August 8, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants