Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: workbench tracing configuration #5453

Merged
merged 4 commits into from
Sep 5, 2023
Merged

nix: workbench tracing configuration #5453

merged 4 commits into from
Sep 5, 2023

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Aug 31, 2023

A configuration for new tracing, comparable to old tracing for benchmarks.
In addition:

  • Namespace fixes for locli
  • Forwarder config changes
  • Namespace fixes for: Forge.StateInfo and Net.Inbound.Governor.Transition
  • No merging of TraceOption configuration. The default is picked, when the TraceOptions are empty

@jutaro jutaro self-assigned this Aug 31, 2023
@jutaro jutaro requested a review from mgmeier August 31, 2023 09:30
TraceOptionForwarder config adoption
* A configuration for new tracing, coparable to old tracing for benchmarks
* Namespace fixes
* Default config without option merging
* forwarder adoption
and forwarding config adoption
@jutaro jutaro marked this pull request as ready for review September 5, 2023 07:45
@jutaro jutaro requested review from a team as code owners September 5, 2023 07:45
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @jutaro

@mgmeier mgmeier added this pull request to the merge queue Sep 5, 2023
Merged via the queue into master with commit aa4af36 Sep 5, 2023
25 checks passed
@mgmeier mgmeier deleted the jutaro/bench-config branch September 5, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants