cardano-node: reduce orphan instances

[smelc]

Contributes to fixing #5470

Description

This PR starts reducing the content of the Cardano.Node.Orphans module.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • roundtrip tests
  • integration tests
    See Runnings tests for more details
• Any changes are noted in the CHANGELOG.md for affected package
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

[Jimbo4350]

LGTM, have you opened PRs in the other relevant repos?

[smelc]

LGTM, have you opened PRs in the other relevant repos?

@Jimbo4350> That's my question for the remaining instances. For those I can't inline the typeclass definition in the positions where it is used. So should I add the instances to the other relevant repos? And then we will use those new instances when we update our dependencies (that's our workflow right?).

[Jimbo4350]

LGTM, have you opened PRs in the other relevant repos?

@Jimbo4350> That's my question for the remaining instances. For those I can't inline the typeclass definition in the positions where it is used. So should I add the instances to the other relevant repos? And then we will use those new instances when we update our dependencies (that's our workflow right?).

Yep add the instances to the relevant repos so in the next release we can remove these orphans.

[smelc]

@Jimbo4350> I started doing the PRs to other repos, e.g. input-output-hk/iohk-monitoring-framework#644

However, I suggest to merge this one soon, as this one - in the current state - is standalone. What do you think?

[smelc]

Created the other PR required to get rid of Orphans.hs: IntersectMBO/ouroboros-network#4674

[smelc]

I'm enqueueing for merge, since in the final state it only removes an unusued orphan instance and is good to go as is.

I've kept track in #5470 of the follow-up work in other repos to further shrink the instances from this repo.

[carbolymer]

@smelc I have no clue what happened to ubuntu runners that they're failing now, but maybe you need to add apt update in GHA workflow to fix them: https://github.com/input-output-hk/cardano-api/pull/248/files#diff-c09cc8dc973415b1221308559b96942a1c4b872e690bf360fc22d9b42822d519R48