Factor out file creation for SPO #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/remove-all-calls-to-rewriteObject
branch
from
8d44f5a to
81095b7
Compare
newhoggy
reviewed
Oct 19, 2023
| -- with the parameters we want. The user must provide genesis files or we will use a default. | ||
| -- We should *never* be modifying the genesis file after cardano-testnet is run because this | ||
| -- is sure to be a source of confusion if users provide genesis files and we are mutating them | ||
| -- without their knowledge. |
newhoggy
reviewed
Oct 19, 2023
newhoggy
reviewed
Oct 19, 2023
newhoggy
reviewed
Oct 19, 2023
newhoggy
reviewed
Oct 19, 2023
| @@ -71,7 +71,7 @@ hprop_leadershipSchedule = H.integrationRetryWorkspace 2 "babbage-leadership-sch | |||
| cTestnetOptions = cardanoDefaultTestnetOptions | |||
| { cardanoNodes = cardanoDefaultTestnetNodeOptions | |||
| , cardanoEpochLength = 1000 | |||
| , cardanoSlotLength = 0.02 | |||
| , cardanoSlotLength = 0.1 | |||
There was a problem hiding this comment.
Can you add an explanation in comments why this is 0.1 now?
There was a problem hiding this comment.
we were rewriting the shelley genesis file with 0.1 so it wasn't being used. I'll leave add a comment.
There was a problem hiding this comment.
Added a message in the commit
newhoggy
approved these changes
Oct 19, 2023
Jimbo4350
force-pushed
the
jordan/remove-all-calls-to-rewriteObject
branch
2 times, most recently
from
6be8fee to
beec2ff
Compare
The slot length was always 0.1 because the shelley genesis was being rewritten in cardanoTestnet The activity coefficient was also being rewritten in cardanoTestnet Update testnet options with epoch length 500 as this was the overriding value due to Shelley genesis rewriting in the cardanoTestnet function
Jimbo4350
force-pushed
the
jordan/remove-all-calls-to-rewriteObject
branch
from
beec2ff to
71f159a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.