Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: nixos node svc topo moved to /etc to allow svc SIGHUP #5537

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

johnalotoski
Copy link
Contributor

@johnalotoski johnalotoski commented Nov 9, 2023

Description

  • Creates a useSystemdReload bool option for the cardano-node nixos service, which will move the topology file(s) to /etc/cardano-node/topology-$i.yaml where $i is the instance id, and inject reload hooks into corresponding node instance systemd services which are configured for p2p.
  • The option defaults to false for backward compatibility
  • Moving topology files to /etc also allows for manual topology updates when a quick test is needed and full service re-deployment isn't desired

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • CI passes. See note on CI. The following CI checks are required:
  • Self-reviewed the diff

@johnalotoski johnalotoski force-pushed the svc-topo-opt branch 6 times, most recently from a2105e4 to 0251423 Compare November 14, 2023 22:44
@johnalotoski johnalotoski marked this pull request as ready for review November 17, 2023 14:59
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; successfully tested with all benchmarking deployment flavours.

@johnalotoski johnalotoski added this pull request to the merge queue Nov 18, 2023
Merged via the queue into master with commit c7bce17 Nov 18, 2023
21 checks passed
@johnalotoski johnalotoski deleted the svc-topo-opt branch November 18, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants