Transaction submission test via cardano-submit-api
#5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/transaction-test-via-submit-api
branch
from
9409dcf
to
983ec70
Compare
newhoggy
changed the title
cardano-submit-api
catch-21
approved these changes
Nov 29, 2023
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/SubmitApi/Babbage/Transaction.hs
Outdated
Show resolved
Hide resolved
| , configPath = configurationFile | ||
| , epochSlots = 2 | ||
| , sprocket = poolSprocket1 | ||
| , port = 8090 |
There was a problem hiding this comment.
Consider randomising ports using allocateRandomPorts as used here to avoid collision when running on our Macs (I've been toldby DevX that the MacOs runners have virtually no isolation)
Jimbo4350
reviewed
Nov 29, 2023
| data SubmitApiConf = SubmitApiConf | ||
| { tempAbsPath :: FilePath | ||
| , configPath :: FilePath | ||
| , epochSlots :: Int |
There was a problem hiding this comment.
Why isn't the epoch slots being read from the config file?
There was a problem hiding this comment.
Not sure. The cardano-submit-api CLI requires it.
newhoggy
force-pushed
the
newhoggy/transaction-test-via-submit-api
branch
from
983ec70
to
40125bc
Compare
carbolymer
approved these changes
Nov 30, 2023
newhoggy
force-pushed
the
newhoggy/transaction-test-via-submit-api
branch
from
40125bc
to
fceae5c
Compare
newhoggy
force-pushed
the
newhoggy/transaction-test-via-submit-api
branch
from
67fc32b
to
0acfd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds transaction submission test that is done via
cardano-submit-api.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.