[DDW-509] Show success message for saving logs #1228
Conversation
|
@a-rukin what do you think of a different opacity for the close button when hovering the notification area? Here it has .5 and .8 when hovering.
|
|
@daniloprates good idea! like it :) |
| actions.profile.downloadLogs.trigger({ fileName, destination, fresh: true }); | ||
| } | ||
| const { id, duration } = this.notification; | ||
| actions.notifications.open.trigger({ id, duration, }); |
There was a problem hiding this comment.
You forgot to check if the downloaded logs are actually successfully saved before showing the notification!
There was a problem hiding this comment.
You are right! Do you think listening to the action is enough or we should actually check if the file exists? I think listening is enough.
| } | ||
| const { id, duration } = this.notification; | ||
| actions.notifications.open.trigger({ id, duration, }); |
There was a problem hiding this comment.
You forgot to check if the downloaded logs are actually successfully saved before showing the notification!
|
Was wondering if a "View in Finder/Open folder" button wouldn't be useful, @a-rukin @nikolaglumac? |
This may cause more bad than good. |
|
@a-rukin fair enough :) |
|
@daniloprates do we have translations for this PR? |
|
|
@daniloprates @darko-mijic I suggest we use the following text for the success message: |
iohk-bors
bot
deleted the
feature/ddw-509-show-success-message-for-saving-logs
branch
This PR implements a success message for logs download.
Todo:
Screenshots:
Review Checklist:
Basics
yarn run test)yarn run dev)yarn run package/ CI builds)yarn run flow:test)yarn run lint)yarn run manage:translationsproduces no changes)yarn run storybook)yarn.lockfile is updatedCode Quality
Testing
After Review:
doneon the Youtrack board