[DDW-545] Update Electron to version 3.0.14 #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication menu items text bug
|
This is still problematic on ubuntu 18.10 normal clicked i am using the default Yaru theme. |
|
@amias-iohk I know. I'm still working on it... |
nikolaglumac
changed the title
|
@amias-iohk apparently they have fixed the issue in 3.0.14 version but not in 3.1.0 (which was released 2 days after it) 🤦♂️ |
|
@amias-iohk @DominikGuzei @DmitriiGaico it is working 🎉
|
DominikGuzei
approved these changes
Jan 14, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 14, 2019
1265: [DDW-545] Update Electron to version 3.0.14 r=DominikGuzei a=nikolaglumac This PR fixes invisible application menu items text issue on Ubuntu 18.10. ## Screenshots: ### Before:  ### After:  --- ## Review Checklist: ### Basics - [ ] PR is updated to the most recent version of target branch (and there are no conflicts) - [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance tests are passing (`yarn run test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn run flow:test`) - [ ] There are no *lint* errors or warnings (`yarn run lint`) - [ ] Text changes are proofread and approved (Jane Wild) - [ ] There are no missing translations (running `yarn run manage:translations` produces no changes) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn run storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly documented and commented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-rendering - [ ] Any code that only works in Electron is neatly separated from components ### Testing - [ ] New feature / change is covered by acceptance tests - [ ] All existing acceptance tests are still up-to-date - [ ] New feature / change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review: - [ ] Merge PR - [ ] Delete source branch - [ ] Move ticket to `done` on the Youtrack board Co-authored-by: Nikola Glumac <niglumac@gmail.com>
iohk-bors
bot
deleted the
fix/ddw-545-update-electron-to-fix-ubuntu-menu-issues
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes invisible application menu items text issue on Ubuntu 18.10.
Screenshots:
Before:
After:
Review Checklist:
Basics
yarn run test)yarn run dev)yarn run package/ CI builds)yarn run flow:test)yarn run lint)yarn run manage:translationsproduces no changes)yarn run storybook)yarn.lockfile is updatedCode Quality
Testing
After Review:
doneon the Youtrack board