Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-hydra-key should not overwrite key if file already exists #1136

Closed
v0d1ch opened this issue Oct 21, 2023 · 0 comments · Fixed by #1139
Closed

gen-hydra-key should not overwrite key if file already exists #1136

v0d1ch opened this issue Oct 21, 2023 · 0 comments · Fixed by #1139
Assignees
Labels
Milestone

Comments

@v0d1ch
Copy link
Contributor

v0d1ch commented Oct 21, 2023

Why

I was bitten by this recently - when generating hydra keys hydra-node should not overwrite existing keys.

What

Detect if the file path we are providing is already present/existing and want the user about this.

How

Alter hydra-node executable gen-hydra-key to look at the provided file path and warn if a file already exists.

@v0d1ch v0d1ch added the 💭 idea An idea or feature request label Oct 21, 2023
@v0d1ch v0d1ch self-assigned this Oct 21, 2023
@ffakenz ffakenz added red bin and removed 💭 idea An idea or feature request labels Oct 23, 2023
@v0d1ch v0d1ch changed the title gen-hydra-key should warn if the key file already exists gen-hydra-key should not overwrite key if file already exists Oct 23, 2023
@ch1bo ch1bo added this to the 0.14.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants