Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User feedback when a command fails is pretty terse #1251

Closed
abailly-iohk opened this issue Jan 15, 2024 · 0 comments · Fixed by #1274
Closed

User feedback when a command fails is pretty terse #1251

abailly-iohk opened this issue Jan 15, 2024 · 0 comments · Fixed by #1274
Assignees
Labels
api Items related to the Hydra client API bug 🐛 Something isn't working tidying A small change improving the "habitability" of the code. Emphasis on small. ux Related to user experience

Comments

@abailly-iohk
Copy link
Contributor

Context & versions

I am connected to a hydra-node and trying to Abort.

I see this over the WS connection

{"tag":"Abort"}
{"clientInput":{"tag":"Abort"},"seq":182,"tag":"CommandFailed","timestamp":"2024-01-15T16:53:06.893436Z"}

and I see the following in the logs

{"timestamp":"2024-01-15T16:53:06.893002Z","threadId":1885,"namespace":"HydraNode-\"hydra\"","message":{"api":{"receivedInput":{"tag":"Abort"},"tag":"APIInputReceived"},"tag":"APIServer"}}
{"timestamp":"2024-01-15T16:53:06.893356Z","threadId":97,"namespace":"HydraNode-\"hydra\"","message":{"node":{"by":{"vkey":"6197ef01d4b8afab12850b1d0f3245b6b196c067dc17f2f86a001285b535a720"},"event":{"clientInput":{"tag":"Abort"},"tag":"ClientEvent"},"eventId":71,"tag":"BeginEvent"},"tag":"Node"}}
{"timestamp":"2024-01-15T16:53:06.893364Z","threadId":97,"namespace":"HydraNode-\"hydra\"","message":{"node":{"by":{"vkey":"6197ef01d4b8afab12850b1d0f3245b6b196c067dc17f2f86a001285b535a720"},"outcome":{"effects":[{"serverOutput":{"clientInput":{"tag":"Abort"},"tag":"CommandFailed"},"tag":"ClientEffect"}],"tag":"Effects"},"tag":"LogicOutcome"},"tag":"Node"}}
{"timestamp":"2024-01-15T16:53:06.893429Z","threadId":97,"namespace":"HydraNode-\"hydra\"","message":{"node":{"by":{"vkey":"6197ef01d4b8afab12850b1d0f3245b6b196c067dc17f2f86a001285b535a720"},"effect":{"serverOutput":{"clientInput":{"tag":"Abort"},"tag":"CommandFailed"},"tag":"ClientEffect"},"effectId":0,"eventId":71,"tag":"BeginEffect"},"tag":"Node"}}
{"timestamp":"2024-01-15T16:53:06.89484Z","threadId":97,"namespace":"HydraNode-\"hydra\"","message":{"node":{"by":{"vkey":"6197ef01d4b8afab12850b1d0f3245b6b196c067dc17f2f86a001285b535a720"},"effectId":0,"eventId":71,"tag":"EndEffect"},"tag":"Node"}}
{"timestamp":"2024-01-15T16:53:06.894847Z","threadId":97,"namespace":"HydraNode-\"hydra\"","message":{"node":{"by":{"vkey":"6197ef01d4b8afab12850b1d0f3245b6b196c067dc17f2f86a001285b535a720"},"eventId":71,"tag":"EndEvent"},"tag":"Node"}}
{"timestamp":"2024-01-15T16:53:06.894971Z","threadId":1886,"namespace":"HydraNode-\"hydra\"","message":{"api":{"sentOutput":{"clientInput":{"tag":"Abort"},"seq":182,"tag":"CommandFailed","timestamp":"2024-01-15T16:53:06.893436Z"},"tag":"APIOutputSent"},"tag":"APIServer"}}
{"timestamp":"2024-01-15T16:53:06.895128Z","threadId":174,"namespace":"HydraNode-\"hydra\"","message":{"api":{"sentOutput":{"clientInput":{"tag":"Abort"},"seq":182,"tag":"CommandFailed","timestamp":"2024-01-15T16:53:06.893436Z"},"tag":"APIOutputSent"},"tag":"APIServer"}}

Steps to reproduce

Try any command that's supposed to fail.

Expected behavior

The CommandFailed output should provide more details about why the command failed, eg. what's the state of the head logic at this point?

@abailly-iohk abailly-iohk added bug 🐛 Something isn't working ux Related to user experience api Items related to the Hydra client API tidying A small change improving the "habitability" of the code. Emphasis on small. labels Jan 15, 2024
@ffakenz ffakenz self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Items related to the Hydra client API bug 🐛 Something isn't working tidying A small change improving the "habitability" of the code. Emphasis on small. ux Related to user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants