Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brick to 1.10 #1103

Merged
1 commit merged into from
Oct 9, 2023
Merged

Update brick to 1.10 #1103

1 commit merged into from
Oct 9, 2023

Conversation

locallycompact
Copy link
Contributor

Updates brick to 1.10

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Test Results

354 tests  ±0   349 ✔️ ±0   16m 57s ⏱️ +22s
120 suites ±0       5 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 8e712e5. ± Comparison against base commit 2a08bc2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-10-09 12:26:17.618708641 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial eaf589de11c6c805af24b759e7794d62661d3db4ade79594892ebaec 4106
νCommit 8dcc1fb34d1ba168dfb0b82e7d1a31956a2db5856f268146b0fd7f2a 2051
νHead e35bdf32cd3806596150c1cbab6ab5456bd957b36019ed2746bf481d 8797
μHead 386ad19467be96131379dacf57a9351a762da2dee3486a855f0409c9* 4151
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4744 11.62 4.58 0.49
2 4950 14.23 5.58 0.52
3 5155 16.41 6.40 0.56
5 5565 21.52 8.36 0.63
10 6590 33.15 12.78 0.80
37 12126 96.72 36.99 1.73

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 599 12.64 4.97 0.31
2 784 16.26 6.61 0.36
3 975 20.11 8.33 0.42
5 1347 28.23 11.94 0.52
10 2282 50.99 21.84 0.82
18 3780 94.76 40.36 1.37

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 823 24.27 9.65 0.45
2 113 1134 37.50 15.05 0.61
3 170 1456 53.29 21.52 0.80
4 224 1773 71.57 29.03 1.02
5 284 2097 91.97 37.46 1.26

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 685 19.23 8.84 0.40
2 905 20.67 10.29 0.43
3 1134 22.38 11.87 0.47
5 1461 25.43 14.51 0.52
10 2573 34.20 22.50 0.70
50 10585 96.37 80.57 1.98

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 713 22.67 10.13 0.44
2 933 24.72 11.82 0.48
3 1187 26.68 13.51 0.52
5 1544 30.34 16.53 0.58
10 2553 39.39 24.34 0.76
42 9043 98.10 74.56 1.88

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4965 21.40 9.23 0.61
2 5409 36.26 15.81 0.80
3 5668 48.09 20.88 0.94
4 6040 69.30 30.23 1.19
5 6846 99.82 44.00 1.58

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4767 8.95 3.77 0.46
5 1 57 4804 9.99 4.46 0.47
5 5 284 4946 15.44 7.74 0.55
5 10 567 5121 21.94 11.72 0.64
5 20 1138 5485 34.94 19.66 0.82
5 30 1708 5848 47.68 27.51 0.99
5 40 2276 6210 60.94 35.57 1.17
5 50 2846 6561 73.43 43.32 1.34
5 70 3985 7282 99.83 59.40 1.71

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-10-09 12:19:50.913527777 UTC

3-nodes Scenario

A rather typical setup, with 3 nodes forming a Hydra head.

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 89.781763920
P99 261.50343804ms
P95 223.74727774999994ms
P50 60.964676999999995ms
Number of Invalid txs 0

Baseline Scenario

This scenario represents a minimal case and as such is a good baseline against which to assess the overhead introduced by more complex setups. There is a single hydra-node d with a single client submitting single input and single output transactions with a constant UTxO set of 1.

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 3.288753260
P99 11.493377689999981ms
P95 6.525325950000001ms
P50 2.62406ms
Number of Invalid txs 0

@abailly
Copy link
Contributor

abailly commented Oct 9, 2023

Can we merge this without merging the change to 9.6.2 ? If so then I would do the move in the relevant (now unblocked) PR and merge that change as is

Copy link
Contributor

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is pretty heavy but I guess that's the price to pay to move across several major versions 🤷 I like the overall structure and intent of the change (eg. separating things into proper modules) and don't want to nitpick so ...
LGTM if we stick to ghc 9.2.8

@locallycompact locallycompact force-pushed the lc/brick-1.10 branch 2 times, most recently from 7cd6712 to 7e2675a Compare October 9, 2023 12:11
@ghost ghost requested a review from abailly October 9, 2023 14:08
@ghost ghost merged commit 6a0f3d4 into master Oct 9, 2023
@ghost ghost deleted the lc/brick-1.10 branch October 9, 2023 14:09
@ghost ghost mentioned this pull request Oct 19, 2023
4 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants