-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUI - Enhance UX to request confirmation for terminating actions #1201
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2023-12-12 18:01:43.931398415 UTC Baseline Scenario
Baseline Scenario
|
@@ -135,15 +136,35 @@ handleVtyEventsInitializingScreen cardanoClient hydraClient e = do | |||
id .= InitializingHome | |||
_ -> pure () | |||
zoom commitMenuL $ handleFormEvent (VtyEvent e) | |||
ConfirmingAbort i -> do | |||
case e of | |||
EvKey KEsc [] -> id .= InitializingHome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id .=
is always confusing me.. why not simply put
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, but it is to keep it consistent with the rest.
do you want to include this refactor as part of this PR?
b9ebcdf
to
5bb820b
Compare
f9b0ff5
to
20f7b3c
Compare
When running the demo on devnet, we observed that due to the fast confirmation time, it is too easy to close a head immediately after collecting the last commit, as the TUI utilizes the same key-binding for both actions.
Moreover, it is a good practice to safeguard such actions in order to prevent accidents.
🎁 Add a confirmation dialog prompt for Close/Abort actions to prevent accidental termination of the head.