-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse mainnet network flag #715
Conversation
I think this should be the last step on #713 and not merged light-heartedly without the right communication in place. |
I tried not to break backwards compatibility so hydra-node, tui, and hydraw should still function as is even with this merged. |
e59dbe3
to
d09600e
Compare
Test Results294 tests +13 288 ✔️ +13 19m 21s ⏱️ - 3m 14s Results for commit aa3022e. ± Comparison against base commit 2bb6a7b. This pull request removes 2 and adds 15 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
It's not about backwards compatibility. It's about making sure that nobody tries this on mainnet and loose funds before we have not properly warned them from it. There are lots of good & important ideas in #713 which we have not even discussed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to discuss #713 before merging this
8dbab10
to
78636e1
Compare
3697af6
to
394b12e
Compare
d763a23
to
043c8fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look and already spotted some inconsistencies. Will complete the review when these are addressed or you actually request the review :)
docs/i18n/ja/docusaurus-plugin-content-docs/current/getting-started/quickstart.md
Outdated
Show resolved
Hide resolved
c25f0cc
to
b86478f
Compare
62f1423
to
a0e905d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inconsistency within hydraw (not so important to block this PR, but ideally fixed)
Also, the Network
type could be pushed further up.
BTW I was wrong with the breaking change on the scripts. The 0.9.0 scripts are actually mainnet compatible.
927d7ad
to
aa3022e
Compare
Why
In order to get mainnet ready I am doing this as the kickoff task - be able to actually connect hydra-node to the mainnet.
This PR:
HYDRAW-NETWORK
that is either parsed as a testnet magic number or defaults to mainnetv_commit
validator related to hardcoded networkTo check before merging: