-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix smoke test #726
Fix smoke test #726
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, I'll spin it locally to see if I can reproduce.
65fe615
to
8b1f920
Compare
32269c9
to
116ea07
Compare
116ea07
to
2778f79
Compare
This is required because the hydra-cluster package is included in this shell environment and it requires submodules to compile.
We really need to make these scenarios fully network-agnostic..
- This scenario also needs to run on a public testnet where block production is usually 20+ seconds. So one second is too low value for a contestation period especially since we use it for calculating the validity range of close tx.
- The smoke tests should clear the hydra-node state on each run so that we do not continue using previous head state.
78cf00d
to
0ccfaad
Compare
Latest run was green 💚 https://github.com/input-output-hk/hydra/actions/runs/4291889526. Thanks @v0d1ch for fixing this, I would approve if I could :) |
Fixes the
exes
nix shell so we can run the smoke test againReverts the wait times back to 600 seconds for the smoke test scenario
Took note of a recently published
hydra-scripts-tx-id
Fixed also the contestation period to a higher value, now 100 seconds instead of 1
Red bin items discovered
Scenarios
by network they run in, i.e. the block production time is a parameter for a good contestation period + max wait time for an end-to-end scenario