-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restarting the node with different parameters #767
Restarting the node with different parameters #767
Conversation
f083c53
to
bfeea14
Compare
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
db868ec
to
297f3f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that, for now, you're not looking for a P.R. per se but for preliminary comments. So here are mine.
Cheers,
2383409
to
6592698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reduce the complexity of this also by not being too strict on the level of detail required. IMO it is sufficient to say, that the loaded state is not matching what was configured. Maybe with another message to indicate check state in --persistence-dir against provided command line options
b22eb8b
to
0b2c0c2
Compare
fe2fcf4
to
5907d57
Compare
5907d57
to
dc8028f
Compare
dc8028f
to
83faa98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inconsistencies still, but I can approve even without these changes.
83faa98
to
1c687ac
Compare
- We want to display all possible misconfigurations to the user not just the first one we encounter
- Add the record accessor so it looks nice in the logs
1c687ac
to
3d1c988
Compare
62cca01
to
58e6415
Compare
58e6415
to
bbe90bf
Compare
7e53b56
to
a2295a6
Compare
a2295a6
to
5f7efd9
Compare
Fix #764
NOTE: This is initial work on this item as I wanted to gather reviews. This PR only checks the contestation period and the parties. If the approach is good I will add more checks to complete our objective.
Why
We want our hydra-node to behave well with respect to the provided arguments. In the presence of existing state it can happen that the arguments are not in line with what we have already in our state. For these cases we want to prevent the hydra-node from operating further until either state is cleared or node arguments match the state.
What
Check node state (if any) against the provided arguments, log and fail if we discover misconfiguration.