enforce the correct order of writes to storage #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the global lock from the storage allowed for better performance. However, there is an issue of writes possibly done out of the expected order due to the underlying pool of parallel sqlite connections or put_block/tag tasks being run in parallel tokio executors. Now we introduce the global write lock for the block storage while still allowing parallel reads.
eugene-babichenko
added
bug
NicolasDP
approved these changes
Jan 3, 2020
|
@NicolasDP Added a comment and renamed the fields of |
|
@mzabaluev , This might be linked to some of the state management issue we saw the last past week in the candidate tree. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the global lock from the storage allowed for better
performance. However, there is an issue of writes possibly done
out of the expected order due to the underlying pool of parallel sqlite
connections or put_block/tag tasks being run in parallel tokio
executors. Now we introduce the global write lock for the block storage
while still allowing parallel reads.
Should fix #1422 (p. 3) #1438