Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCLI: transaction info - remove args positionality #910

Merged
merged 1 commit into from
Oct 8, 2019
Merged

JCLI: transaction info - remove args positionality #910

merged 1 commit into from
Oct 8, 2019

Conversation

rinor
Copy link
Contributor

@rinor rinor commented Oct 8, 2019

Convert positional arguments to normal ones.
Why? Readability and practicity.
Ex: If we want to get only the balance value without input/output lines:

jcli transaction info 
  --staging tx.staging
  --fee-certificate 10000
  --fee-coefficient 50
  --fee-constant 1000
  --format {balance}
  "output_file.txt" // forced usage if we need to use the following params
  false
  false
  false
  ""
  ""
  ""

// need to read output_file.txt for result

VS:

jcli transaction info
  --staging tx.staging
  --fee-certificate 10000
  --fee-coefficient 50
  --fee-constant 1000
  --format {balance}
  --format-account-input ""
  --format-utxo-input ""
  --format-output ""

labels: jcli, enhancement, breaking-change

@NicolasDP NicolasDP added breaking-change enhancement New feature or request A-jcli Area: Command Line Interface and tooling labels Oct 8, 2019
@NicolasDP NicolasDP requested a review from a team October 8, 2019 11:48
@NicolasDP NicolasDP self-assigned this Oct 8, 2019
@NicolasDP
Copy link
Contributor

THanks, I am a bit concerned about the breaking change. But it is one of the small breaking change that can be done without breaking everything up.

@NicolasDP NicolasDP merged commit f0e869c into input-output-hk:master Oct 8, 2019
@rinor rinor deleted the jcli_transaction_info branch October 8, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-jcli Area: Command Line Interface and tooling breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants