[LW 10170] Store own addresses from all wallets and accounts #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-barros
requested review from
a team,
DominikGuzei,
mkazlauskas,
renanvalentin and
VanessaPC
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
from
143c19f
to
e2f2126
Compare
Allure report
smokeTests: ✅ test report for 1b6b1ae6
|
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
from
e2f2126
to
f980550
Compare
|
Changes unknown |
VanessaPC
approved these changes
Apr 8, 2024
.../browser-extension-wallet/src/lib/scripts/background/__tests__/cache-wallets-address.test.ts
Show resolved
Hide resolved
apps/browser-extension-wallet/src/lib/scripts/background/cache-wallets-address.ts
Show resolved
Hide resolved
DominikGuzei
reviewed
Apr 8, 2024
| walletId: activeWallet.walletId, | ||
| metadata: { | ||
| ...wallet.metadata, | ||
| addresses: [...addresses] |
There was a problem hiding this comment.
Maybe addresses is a bit too generic for the metadata section of the active wallet? (i think this could easily be misinterpreted as only the active wallets addresses). What about allWalletsAddresses or something more descriptive?
There was a problem hiding this comment.
Makes sense, updated here: 3d29a04
DominikGuzei
approved these changes
Apr 8, 2024
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
4 times, most recently
from
581cc5e
to
95b43a8
Compare
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
2 times, most recently
from
25e5f76
to
29f1e84
Compare
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
2 times, most recently
from
efc5083
to
07aac21
Compare
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
2 times, most recently
from
3931828
to
fb4f957
Compare
|
This looks good to me @lucas-barros , great work! |
| }); | ||
| }); | ||
|
|
||
| it('should not save duplicated addresses', () => { |
There was a problem hiding this comment.
isn't this already tested in the previous case?
|
re-approved 👍 |
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
from
fb4f957
to
58a32a4
Compare
DominikGuzei
force-pushed
the
feat/lw-10061-flag-addresses-as-own-or-foreign
branch
2 times, most recently
from
3e39c9e
to
b1f7f45
Compare
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
from
58a32a4
to
e28823f
Compare
Base automatically changed from
feat/lw-10061-flag-addresses-as-own-or-foreign
to
main
April 19, 2024 16:36
lucas-barros
force-pushed
the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
from
e28823f
to
1b6b1ae
Compare
|
lucas-barros
deleted the
feat/lw-10170-store-own-addresses-from-all-wallets-and-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Store all wallets addresses in each wallet repository metadata
Testing
Account or wallet needs to be activated at least once before making a transaction.
Make transactions between different accounts or wallets and see that receiving addresses is correctly tagged as "own".
Screenshots
Attach screenshots here if implementation involves some UI changes