-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LW-9482] Fix/cip30 sign data #807
Conversation
this allows a callback to be executed on success after signing data
Allure report
smokeTests: ✅ test report for 72bf4d60
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot one small think, but it's not a deal breaker :)
dd5bf58
to
72bf4d6
Compare
Quality Gate failedFailed conditions C Reliability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
* fix(extension): add wrapped callback for signBlob this allows a callback to be executed on success after signing data * fix: use correct method for hardware wallet data signing * refactor: rename callback method * test(extension): add e2e test / add support for console logs collection --------- Co-authored-by: Lukasz Jagiela <Lukasz.Jagiela@iohk.io>
Checklist
Proposed solution
signBlob
method from keyAgent is now also wrapped, so that the auto-redirect to sign success state can be removed, this was prematurely removing password from memory which caused the blob not to signTesting
Execute at example.com in console
Screenshots
Fixes #803