Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate hashes re-computation in aggregator #1343

Closed
8 tasks done
jpraynaud opened this issue Nov 13, 2023 · 0 comments · Fixed by #1345
Closed
8 tasks done

Fix certificate hashes re-computation in aggregator #1343

jpraynaud opened this issue Nov 13, 2023 · 0 comments · Fixed by #1345
Assignees
Labels
devX 🌞 Developer experience manual-deployment 👷 Needs manual deployment

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Nov 13, 2023

Why

Following the merging of the PR #1333, we have run the certificate hashes re-computation runbook, we have faced multiple difficulties we'd like to fix.

What

The migration was not planned and thus not run locally previously to the merge, which gave only a very short delay to run the aforementioned migration. In order to limit the human factor we need to create a manual-deployment tag which will mark the PR needing a manual operation after merging, and a "Team Golden Rules" to which all the teammates agree.

Also the migration process needs to be more robust and fixed accordingly

How

  • Activate a manual-deployment label in GitHub issues
  • Redact team golden rules in the Project Charter wiki page
  • Fix certificate hashes re-computation tool in aggregator:
    • Maximum variables in SQL query reached with batch insert of new certificates
    • Tolerate rec-computation where not all the certificates change (e.g. genesis certificate could not have their hash modified)
    • Remove unnecessarily required configuration parameters to run the command (keep only the database store directory)
    • Verify date format discrepancy on all networks (see InvalidData("Could not turn string '2023-05-09 13:11:15' to rfc3339 Datetime. Error: premature end of input") errors on testing-preview)
  • Fix runbook with aggregator being fully stopped during migration process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devX 🌞 Developer experience manual-deployment 👷 Needs manual deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant