Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sqlite dependency from mithril-client crate #1390

Closed
1 task done
jpraynaud opened this issue Dec 5, 2023 · 0 comments · Fixed by #1391
Closed
1 task done

Remove sqlite dependency from mithril-client crate #1390

jpraynaud opened this issue Dec 5, 2023 · 0 comments · Fixed by #1391
Assignees
@jpraynaud
Labels
devX 🌞 Developer experience

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Dec 5, 2023 •
edited
Loading

Why

While testing the mithril-client library in oura, TxPipe found out that there is a dependency to sqlite which is not needed (and creates some dependency resolution troubles).

What

Remove the dependency to sqlite from mithril-client

How

  • Remove the database feature from mithril-common dependency in mithril-client
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Dec 5, 2023
@jpraynaud jpraynaud self-assigned this Dec 5, 2023
@jpraynaud jpraynaud mentioned this issue Dec 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpraynaud jpraynaud

Labels
devX 🌞 Developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mithril-client dependencies input-output-hk/mithril
1 participant
@jpraynaud