Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTTP server tests more robust #1524

Closed
2 tasks done
jpraynaud opened this issue Feb 23, 2024 · 0 comments · Fixed by #1543
Closed
2 tasks done

Make HTTP server tests more robust #1524

jpraynaud opened this issue Feb 23, 2024 · 0 comments · Fixed by #1543
Assignees
@sfauvel @dlachaume
Labels
testing 🔁 Something related to tests

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Feb 23, 2024 •
edited by dlachaume
Loading

Why

The unit tests that we run today run the HTTP server of the aggregator are missing verification of the status code. The only thing that is verified is the overall validity of the response against the Open API specification.

What

The tests of the HTTP server of the aggregator should verify that the returned status code is the one that is expected.

How

  • Make the APISpec tool support status code enforcement
  • Adapt all existing HTTP tests in the aggregator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
testing 🔁 Something related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve aggregator HTTP server tests input-output-hk/mithril
3 participants
@sfauvel @jpraynaud @dlachaume