Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple beacon types in signer/aggregator #1562

Closed
10 tasks done
Tracked by #1457
jpraynaud opened this issue Mar 11, 2024 · 0 comments
Closed
10 tasks done
Tracked by #1457

Support multiple beacon types in signer/aggregator #1562

jpraynaud opened this issue Mar 11, 2024 · 0 comments
Assignees
Labels
feature 🚀 New implemented feature

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Mar 11, 2024

Why

The Cardano transactions should be signed given a beacon based on Block range, and it should cohabit with the existing system of beacons based on Epoch/Immutable file number. The current design is based on a beacon specific to immutable files and is not versatile enough to support all the upcoming types.

Note: The chain observer will probably need to retrieve the current block number as a new function in the trait

What

We need to adapt the structure of the beacon to support the addition of one or multiple types that will define points on the chain with different semantics. This will have a high impact on the code base and we want to avoid breaking changes.

How

  • Make a PoC or exploratory version where we can assess the amount of work, difficulties, blockers:
    • Use an enum for Beacon and one of its variants is ImmutableFile?
    • Use a trait to represent a Beaconable?
    • Use a generic Beacon?
    • Create a beacon specific to the state machine?
    • Reuse existing SignedEntityType enum ?
  • Use updated version for the new deprecated tags in rust
  • Plan deployments:
    • Breaking changes
    • Manual updates
@jpraynaud jpraynaud added prototype 🛠️ Prototype/PoC of a feature feature 🚀 New implemented feature labels Mar 11, 2024
@jpraynaud jpraynaud mentioned this issue Mar 28, 2024
4 tasks
@jpraynaud jpraynaud removed the prototype 🛠️ Prototype/PoC of a feature label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 New implemented feature
Projects
None yet
Development

No branches or pull requests

4 participants