Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate portable feature in mithril-stm by default #1613

Closed
4 tasks done
jpraynaud opened this issue Apr 4, 2024 · 0 comments
Closed
4 tasks done

Activate portable feature in mithril-stm by default #1613

jpraynaud opened this issue Apr 4, 2024 · 0 comments
Assignees
Labels
devX 🌞 Developer experience

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Apr 4, 2024

Why

blst library has implemented a runtime switch to ADX with the portable feature since 0.3.11. We want to build our binaries in the CI with this feature to avoid having some users forced to compile the binaries on their machine when their CPU is not compatible with ADX.

What

Compile pre-built binaries in CI with portable feature. If possible, we can get rid of the portable feature.

How

  • Compile pre-built binaires with portable feature
  • Activate portable as default in our crates
  • Get rid of portable feature if possible and simplify CI workflow
  • Remove mention to manual build in documentation SPO guide (see PR)
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devX 🌞 Developer experience
Projects
None yet
Development

No branches or pull requests

2 participants