ouroboros-network update (big ledger peers) #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
commented
Jun 19, 2023
ouroboros-consensus-cardano/src/tools/Cardano/Tools/ImmDBServer/MiniProtocols.hs
Outdated
Show resolved
Hide resolved
coot
commented
Jun 19, 2023
ouroboros-consensus-cardano/src/tools/Cardano/Tools/ImmDBServer/MiniProtocols.hs
Outdated
Show resolved
Hide resolved
coot
commented
Jun 19, 2023
ouroboros-consensus-cardano/src/tools/Cardano/Tools/ImmDBServer/Diffusion.hs
Outdated
Show resolved
Hide resolved
coot
changed the title
coot
force-pushed
the
coot/eclipse-evasion
branch
2 times, most recently
from
8b9808d to
fcd478f
Compare
coot
force-pushed
the
coot/eclipse-evasion
branch
2 times, most recently
from
a762dd7 to
d153aec
Compare
nfrisby
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Excellent! Thank you for the very clean diff. Everything looks very reasonable.
The only thing missing is a changelog entry. Here's our docs about how to create one:
If that's too annoying, please ping me and I can created the necessary file for you. Then you'll merely need to fill it in. Because some type signatures change in this PR, I'm pretty sure this constitutes a Breaking change.
|
@nfrisby I added changelogs. I am very happy with the new api in |
coot
force-pushed
the
coot/eclipse-evasion
branch
from
03cb2f9 to
54b89f6
Compare
coot
force-pushed
the
coot/eclipse-evasion
branch
from
54b89f6 to
fa27a65
Compare
nfrisby
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes due to introduction of big ledger peers (eclipse evasion).