Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the latest releases #308

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Patch the latest releases #308

merged 1 commit into from
Aug 21, 2023

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Aug 21, 2023

The recent changes to our expose-sublibs cabal flag prevented a CHaP release.

Instead of embellishing CHaP, we've simplified our packaging, removing the flag. See PR #304.

The recent changes to our `expose-sublibs` cabal flag prevented a CHaP release.

Instead of embellishing CHaP, we've simplified our packaging, removing the flag.
See PR #304.
@nfrisby nfrisby added the release PRs that prepare releases label Aug 21, 2023
@nfrisby nfrisby requested a review from a team as a code owner August 21, 2023 16:09
@nfrisby
Copy link
Contributor Author

nfrisby commented Aug 21, 2023

The unpatched versions will never be on CHaP. If, hypothetically, they were, then we really should be bumping the lower-bounds here. Thus: if they ever do get released (accidentally?), we could consider a revision.

I'm skipping this step for now because it's arduous to find all the necessary places in the cabal files, it's not obviously necessary (see above paragraph), and I'm trying to unblock downstream teams with this PR.

@nfrisby nfrisby enabled auto-merge August 21, 2023 16:17
@nfrisby nfrisby added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 42dbbf4 Aug 21, 2023
8 of 11 checks passed
@nfrisby nfrisby deleted the nfrisby/mid-august-releases3 branch August 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PRs that prepare releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants