-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require that LedgerView family is empty #355
Conversation
This relatively large diff emerges from merely adding the I had originally planned to declare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the major alternative to this approach is to replace all occurrences of Ticked (LedgerView p)
with LedgerView p
.
Perhaps renaming it to TickedLedgerView p
?
@@ -188,27 +191,24 @@ forgePBftFields contextDSIGN PBftIsLeader{..} toSign = | |||
Information PBFT requires from the ledger | |||
-------------------------------------------------------------------------------} | |||
|
|||
newtype PBftLedgerView c = PBftLedgerView { | |||
-- | ProtocolParameters: map from genesis to delegate keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have kept this haddock comment
@@ -438,7 +440,7 @@ append PBftConfig{} PBftWindowParams{..} = | |||
-- avoid space leaks. | |||
data PBftValidationErr c | |||
= PBftInvalidSignature !Text | |||
| PBftNotGenesisDelegate !(PBftVerKeyHash c) !(PBftLedgerView c) | |||
| PBftNotGenesisDelegate !(PBftVerKeyHash c) !(Ticked (PBftLedgerView c)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only aspect of the diff that I anticipate trickling down into eg cardano-node
.
Another idea: push the evidence that |
I much prefer this alternative idea #363, so I'm Closing this. |
Enforcing this property as in this PR is not actually necessary, but we suspect it may prevent a good deal of confusion.