Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Design - Renamed Gossip to Peer Sharing #3980

Closed
wants to merge 1 commit into from

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Aug 29, 2022

Description

This PR updates the existing Network Design document to use the right words when it refers to Gossip. In essence renames (when appropriate) "gossip" to "peer sharing".

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@bolt12 bolt12 requested review from coot and njd42 as code owners August 29, 2022 13:47
@bolt12 bolt12 force-pushed the bolt12/network-design branch from c953168 to 1a401bd Compare August 29, 2022 13:50
@bolt12
Copy link
Contributor Author

bolt12 commented Jan 4, 2023

closing in favor of #4019

@bolt12 bolt12 closed this Jan 4, 2023
@bolt12 bolt12 deleted the bolt12/network-design branch May 8, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant