-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTxO-HD: start documentation report #4060
UTxO-HD: start documentation report #4060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we could merge this to the feature branch. At some point we should include into feature/utxo-hd the documents Duncan wrote.
On Byron, some addresses existed there to be reclaimed by | ||
investors\footnote{These were called AVVM addresses. Perhaps the Ledger team can | ||
tell more about them}, and as some were never reclaimed, the ledger made the | ||
decision of giving the Ada in those addresses back to the treasury. This | ||
happened on the Allegra boundary, and therefore the ledger state has been | ||
modified to keep track of this information so that the era transition can | ||
consume these entries into the treasury and return a set of deletions of those | ||
addresses on the UTxO set. | ||
|
||
See \texttt{Cardano.Ledger.Allegra.Translation.shelleyToAllegraAVVMsToDelete}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the first version of the anti-diff integration where forwarding would still perform sanity checks on the inserts/deletes, this translation proved to be a bit hairy. In particular, the translation would emit the AVVM deletions as diffs, but flushing these diffs to the in-memory backing store would error. My understanding was that it would error because the diffs declared values to be deleted even though these values were not present in the backing store.
https://github.com/input-output-hk/ouroboros-network/tree/jdral/bugfix-shelley-allegra-translation fixes this issue by not emitting the deletions as diffs. I'm not sure if this is a correct fix though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was that it would error because the diffs declared values to be deleted even though these values were not present in the backing store.
This is wrong. The values are in the backing store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Hope they are useful. I haven't gotten to the MemPool part yet. Will do that tomorrow.
034effa
to
cb86fd8
Compare
675b932
to
503d040
Compare
503d040
to
6ec7ec6
Compare
…ool-rewrite-utxo-hd UTxO-HD: start documentation report
Description
Builds on top of #4049.
Starts a document that serves as an extension to the report concerning only UTxO-HD. In particular it describes how the mempool works at the moment.
Closes #4053.