Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/HardWonWisdom.md: on how Ledger uses EpochInfo #4174

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Nov 22, 2022

Starting a new document to capture small bites of knowledge as we accumulate them.

Step one is recording them at all; this file is supposed to make that easy.
Step two would be to occasionally extract cohesive insights from this bag, creating new documents or refining old ones accordingly.

@nfrisby nfrisby added the consensus issues related to ouroboros-consensus label Nov 22, 2022
@nfrisby nfrisby requested a review from amesgen November 22, 2022 01:08
@nfrisby nfrisby requested a review from dnadales as a code owner November 22, 2022 01:08
@nfrisby nfrisby force-pushed the nfrisby/ledger-epochinfo-notes branch 2 times, most recently from d6c7a65 to 88b3b8f Compare November 22, 2022 01:17
Copy link
Member

@dnadales dnadales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, however, as you stated in the PR desc we should not forget to curate the relevant bit and pieces and place them in more appropriate places if there are any (eg code comments or the report).

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very good exposition 👍

I closed #4146 and pushed a tiny commit referencing this new section at the relevant code snippet, as also remarked by @dnadales.

ouroboros-consensus/docs/HardWonWisdom.md Outdated Show resolved Hide resolved
ouroboros-consensus/docs/HardWonWisdom.md Outdated Show resolved Hide resolved
ouroboros-consensus/docs/HardWonWisdom.md Outdated Show resolved Hide resolved
@nfrisby nfrisby force-pushed the nfrisby/ledger-epochinfo-notes branch from 43537f8 to 2bfb80d Compare November 22, 2022 20:31
@nfrisby
Copy link
Contributor Author

nfrisby commented Nov 22, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 22, 2022
4174: docs/HardWonWisdom.md: on how Ledger uses EpochInfo r=nfrisby a=nfrisby

Starting a new document to capture small bites of knowledge as we accumulate them.

Step one is recording them at all; this file is supposed to make that easy.
Step two would be to occasionally extract cohesive insights from this bag, creating new documents or refining old ones accordingly.

Co-authored-by: Nicolas Frisby <nick.frisby@iohk.io>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 22, 2022

Timed out.

@amesgen
Copy link
Member

amesgen commented Nov 23, 2022

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 23, 2022

@iohk-bors iohk-bors bot merged commit ae01a8c into master Nov 23, 2022
@iohk-bors iohk-bors bot deleted the nfrisby/ledger-epochinfo-notes branch November 23, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants