Open Source Readiness #4218
Merged
Open Source Readiness #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Dec 7, 2022
coot
commented
- Removed not used cabal file
- Updated README.md file
- Added CODE_OF_CONDUCT.md file
- Added Roles & Responsibilities section to CONTRIBUTING.md
kevinhammond
reviewed
Dec 7, 2022
| @@ -0,0 +1 @@ | |||
| See https://github.com/input-output-hk/cardano-engineering-handbook/blob/main/CODE-OF-CONDUCT.md | |||
There was a problem hiding this comment.
Be aware that this URL might need to be updated in future, of course
kevinhammond
reviewed
Dec 7, 2022
kevinhammond
reviewed
Dec 7, 2022
kevinhammond
reviewed
Dec 7, 2022
| It now lives in a separate repository. | ||
| * `network-mux` - implementation of a general network muliplexer. | ||
| * `ouroboros-network-api` - shared API between `network` and `consensus` components. | ||
| * `ouroboros-network-framework` - low level network components, e.g. snockets, |
There was a problem hiding this comment.
Snocket combines Socket API & Windows Named Pipes API.
coot
force-pushed
the
coot/mbo-readyness
branch
2 times, most recently
from
a40c797 to
3f230b9
Compare
kevinhammond
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Just spotted a few small typos. Maybe also add
Purpose: This repository contains the core components of the network & consensus code for the Cardano node. It is a dependency when building the node from the cardano-node repository.
to README.md - then we can cross off another requirement
dnadales
reviewed
Dec 7, 2022
dnadales
reviewed
Dec 7, 2022
dnadales
approved these changes
Dec 7, 2022
coot
force-pushed
the
coot/mbo-readyness
branch
from
3f230b9 to
f3f1dc2
Compare
9 tasks
Link to the `CODE_OF_CONDUCT` from Cardano Engineering Handbook.
coot
force-pushed
the
coot/mbo-readyness
branch
from
f3f1dc2 to
2525795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.