mux: MakeBearer interface #4260
Merged
+472
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/mux-bearer
branch
3 times, most recently
from
622a52f to
24a7ccd
Compare
coot
force-pushed
the
coot/mux-bearer
branch
2 times, most recently
from
581e072 to
82c4e09
Compare
bolt12
approved these changes
Jan 11, 2023
Comment on lines
+55
to
+56
| -> DiffTime -> Tracer m MuxTrace -> fd -> m (MuxBearer m) | ||
| pureBearer f = \sduTimeout tr fd -> pure (f sduTimeout tr fd) |
There was a problem hiding this comment.
Can also do 😛
Suggested change
| -> DiffTime -> Tracer m MuxTrace -> fd -> m (MuxBearer m) | |
| pureBearer f = \sduTimeout tr fd -> pure (f sduTimeout tr fd) | |
| -> (DiffTime -> Tracer m MuxTrace -> fd -> m (MuxBearer m)) | |
| pureBearer f = fmap (fmap (fmap pure)) f |
coot
force-pushed
the
coot/mux-bearer
branch
4 times, most recently
from
24d2da8 to
419d2ab
Compare
Provide a `MakeBearer` newtype: a function to constructs a `MuxBearer`. Although all instantiations are pure, we need to return a monadic action to accommodate bearer for simulated snocket in `Simulation.Network.Snocket`. The `MakeBearer` function provides default `SDUSize`s. One can still use a custom size by using one of the low level `*AsMuxBearer` functions. We remove `toBearer` method of the `Snocket` api.
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 18, 2023
4260: mux: MakeBearer interface r=coot a=coot Provide a `Bearer` type class. The main function is `makeBearer` which constructs a `MuxBearer` with the `defaultSDUSize`. The `makeBearer'` function is useful for testing preposes. Although all instances are pure, we need to return a monadic action to accommodate bearer for simulated snocket in `Simulation.Network.Snocket`. The goal is to remove `toBearer` method from `Snocket` interface. TODO: * [ ] Update `CHANGELOG.md` files Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Build failed: |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 18, 2023
4260: mux: MakeBearer interface r=coot a=coot Provide a `Bearer` type class. The main function is `makeBearer` which constructs a `MuxBearer` with the `defaultSDUSize`. The `makeBearer'` function is useful for testing preposes. Although all instances are pure, we need to return a monadic action to accommodate bearer for simulated snocket in `Simulation.Network.Snocket`. The goal is to remove `toBearer` method from `Snocket` interface. TODO: * [ ] Update `CHANGELOG.md` files Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Build failed: |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a
Bearertype class. The main function ismakeBearerwhich constructs a
MuxBearerwith thedefaultSDUSize. ThemakeBearer'function is useful for testing preposes. Although allinstances are pure, we need to return a monadic action to accommodate
bearer for simulated snocket in
Simulation.Network.Snocket.The goal is to remove
toBearermethod fromSnocketinterface.TODO:
CHANGELOG.mdfiles