Fix a bug in peer-state-actions #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the monitoring loop notices a hot to warm or cold demotion it executes `deactivatePeerConnection` or `closePeerConnection` to make sure all hot or hot & warm & established mini-protocols terminate. Both operations can throw, if they do they shutdown mux. In this case we should not continue running the monitoring loop but let it die, otherwise we have a tight busy loop which will is eventually exited when mux exits.
|
LGTM. |
coot
force-pushed
the
coot/peer-state-actions-1.35
branch
from
eb3d180 to
8c86041
Compare
coot
force-pushed
the
coot/peer-state-actions-1.35
branch
from
8c86041 to
64e0c3c
Compare
coot
force-pushed
the
coot/peer-state-actions-1.35
branch
from
349c1e5 to
5f2415f
Compare
coot
force-pushed
the
coot/peer-state-actions-1.35
branch
from
5f2415f to
4afc515
Compare
|
Thank you @kevinhammond. bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 15, 2023
4357: Fix a bug in peer-state-actions r=coot a=coot
# Description
Fixed a bug in peer state actions: when demoting a peer from hot to warm the
monitoring loop might busy loop.
- peer-state-actions: do not catch exceptions in the monitoring loop
- peer-selection: filter out empty traces
# Checklist
- Branch
- [x] Commit sequence broadly makes sense
- [x] Commits have useful messages
- [ ] The documentation has been properly updated
- [ ] New tests are added if needed and existing tests are updated
- [ ] Any changes affecting Consensus packages must have an entry in the appropriate `changelog.d` directory created using [`scriv`](https://github.com/input-output-hk/scriv). If in doubt, see the [Consensus release process](../ouroboros-consensus/docs/ReleaseProcess.md).
- [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../docs/interface-CHANGELOG.md)
- [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
- Pull Request
- [x] Self-reviewed the diff
- [ ] Useful pull request description at least containing the following information:
- What does this PR change?
- Why these changes were needed?
- How does this affect downstream repositories and/or end-users?
- Which ticket does this PR close (if any)? If it does, is it [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)?
- [ ] Reviewer requested
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
Co-authored-by: Robin Stumm <robin.stumm@iohk.io>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: John Ky <newhoggy@gmail.com>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 15, 2023
4357: Fix a bug in peer-state-actions r=coot a=coot
# Description
Fixed a bug in peer state actions: when demoting a peer from hot to warm the
monitoring loop might busy loop.
- peer-state-actions: do not catch exceptions in the monitoring loop
- peer-selection: filter out empty traces
# Checklist
- Branch
- [x] Commit sequence broadly makes sense
- [x] Commits have useful messages
- [ ] The documentation has been properly updated
- [ ] New tests are added if needed and existing tests are updated
- [ ] Any changes affecting Consensus packages must have an entry in the appropriate `changelog.d` directory created using [`scriv`](https://github.com/input-output-hk/scriv). If in doubt, see the [Consensus release process](../ouroboros-consensus/docs/ReleaseProcess.md).
- [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../docs/interface-CHANGELOG.md)
- [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
- Pull Request
- [x] Self-reviewed the diff
- [ ] Useful pull request description at least containing the following information:
- What does this PR change?
- Why these changes were needed?
- How does this affect downstream repositories and/or end-users?
- Which ticket does this PR close (if any)? If it does, is it [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)?
- [ ] Reviewer requested
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
Co-authored-by: Robin Stumm <robin.stumm@iohk.io>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: John Ky <newhoggy@gmail.com>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 15, 2023
4357: Fix a bug in peer-state-actions r=coot a=coot
# Description
Fixed a bug in peer state actions: when demoting a peer from hot to warm the
monitoring loop might busy loop.
- peer-state-actions: do not catch exceptions in the monitoring loop
- peer-selection: filter out empty traces
# Checklist
- Branch
- [x] Commit sequence broadly makes sense
- [x] Commits have useful messages
- [ ] The documentation has been properly updated
- [ ] New tests are added if needed and existing tests are updated
- [ ] Any changes affecting Consensus packages must have an entry in the appropriate `changelog.d` directory created using [`scriv`](https://github.com/input-output-hk/scriv). If in doubt, see the [Consensus release process](../ouroboros-consensus/docs/ReleaseProcess.md).
- [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../docs/interface-CHANGELOG.md)
- [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
- Pull Request
- [x] Self-reviewed the diff
- [ ] Useful pull request description at least containing the following information:
- What does this PR change?
- Why these changes were needed?
- How does this affect downstream repositories and/or end-users?
- Which ticket does this PR close (if any)? If it does, is it [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)?
- [ ] Reviewer requested
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
Co-authored-by: Robin Stumm <robin.stumm@iohk.io>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: John Ky <newhoggy@gmail.com>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
4357: Fix a bug in peer-state-actions r=coot a=coot
# Description
Fixed a bug in peer state actions: when demoting a peer from hot to warm the
monitoring loop might busy loop.
- peer-state-actions: do not catch exceptions in the monitoring loop
- peer-selection: filter out empty traces
# Checklist
- Branch
- [x] Commit sequence broadly makes sense
- [x] Commits have useful messages
- [ ] The documentation has been properly updated
- [ ] New tests are added if needed and existing tests are updated
- [ ] Any changes affecting Consensus packages must have an entry in the appropriate `changelog.d` directory created using [`scriv`](https://github.com/input-output-hk/scriv). If in doubt, see the [Consensus release process](../ouroboros-consensus/docs/ReleaseProcess.md).
- [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in [`interface-CHANGELOG.md`](../docs/interface-CHANGELOG.md)
- [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
- Pull Request
- [x] Self-reviewed the diff
- [ ] Useful pull request description at least containing the following information:
- What does this PR change?
- Why these changes were needed?
- How does this affect downstream repositories and/or end-users?
- Which ticket does this PR close (if any)? If it does, is it [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)?
- [ ] Reviewer requested
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
Co-authored-by: Robin Stumm <robin.stumm@iohk.io>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: John Ky <newhoggy@gmail.com>
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in peer state actions: when demoting a peer from hot to warm the
monitoring loop might busy loop.
Checklist
changelog.ddirectory created usingscriv. If in doubt, see the Consensus release process.interface-CHANGELOG.md