Implement header-body split (make block-fetch actually work) in diffusion tests #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
changed the title
coot
reviewed
Mar 28, 2023
| . withTimeNameTraceEvents | ||
| @DiffusionTestTrace | ||
| @NtNAddr | ||
| . Trace.fromList (MainReturn (Time 0) () []) |
There was a problem hiding this comment.
I don't think we should use fromList and then toList, can we just operate on a list?
There was a problem hiding this comment.
There's no easy way to just operate on a single type. The trace comes in a different type and if we only want to analyze 125k worth of traces the easiest way is to convert to a list an take .
There was a problem hiding this comment.
Right, my question was if we can operate on a list without using Trace by avoiding the toList.
There was a problem hiding this comment.
I mean we probably can, but it is more convenient to use lists here imo. It should get fused away no? We're going to end up to need a list for tabulate
ouroboros-network/test/Test/Ouroboros/Network/Testnet/Simulation/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/Testnet/Simulation/Node.hs
Outdated
Show resolved
Hide resolved
Also adds a test to check for coverage of TraceFetchClient traces
But only for diffusion tests. For other tests it was more tricky to change this fact because some technical debt exists and it would be more complex to change. For those functions we just plucked 'id' as the 'block -> header' function. Also for the chain sync clients and servers we had to make the Point type to be parameterised by the block instead of the header due to some very specific types used in consensus, since we can just cast the points I went to the least friction path.
|
bump |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4389