Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GHA situation #4421

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Improve GHA situation #4421

merged 3 commits into from
Mar 6, 2023

Conversation

jasagredo
Copy link
Contributor

Description

  • Builds only with ghc-9.2.5 on windows
  • Builds only on non-draft PRs
  • Doesn't build Consensus on GHA
  • Inexpensive checks are aggregated into one workflow

@jasagredo jasagredo requested review from coot, newhoggy, a team, bolt12 and nfrisby as code owners March 2, 2023 11:47
@jasagredo jasagredo requested review from amesgen, a user, dnadales and bartfrenk March 2, 2023 11:48
@jasagredo jasagredo self-assigned this Mar 2, 2023
@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from 849a0d0 to 915c3cf Compare March 2, 2023 11:52
bolt12
bolt12 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! :)

@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch 3 times, most recently from 6e68db6 to 390d1ed Compare March 2, 2023 12:14
coot
coot reviewed Mar 2, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from 390d1ed to 77e7b0f Compare March 2, 2023 12:40
amesgen
amesgen reviewed Mar 2, 2023
View reviewed changes
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
.github/workflows/cabal.project.local.Windows Outdated Show resolved Hide resolved
@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch 3 times, most recently from e0bcb09 to 6adc0a4 Compare March 3, 2023 11:24
@jasagredo
Copy link
Contributor Author

I went into my Windows/MinGW machine and made sure this builds. Merging

@jasagredo
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Configuration problem:
bors.toml: syntax error

@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from 6adc0a4 to de0c954 Compare March 3, 2023 11:28
@jasagredo
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 3, 2023
@iohk-bors @jasagredo
Merge #4421
4ed9b92 
4421: Improve GHA situation r=Jasagredo a=Jasagredo

# Description

- Builds only with `ghc-9.2.5` on windows
- Builds only on non-draft PRs
- Doesn't build Consensus on GHA
- Inexpensive checks are aggregated into one workflow


Co-authored-by: Javier Sagredo <jasataco@gmail.com>
@jasagredo
Copy link
Contributor Author

bors cancel

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Canceled.

@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from de0c954 to fbf4e2e Compare March 3, 2023 14:02
@jasagredo
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 3, 2023
@iohk-bors @jasagredo
Merge #4421
2bca4c7 
4421: Improve GHA situation r=Jasagredo a=Jasagredo

# Description

- Builds only with `ghc-9.2.5` on windows
- Builds only on non-draft PRs
- Doesn't build Consensus on GHA
- Inexpensive checks are aggregated into one workflow


Co-authored-by: Javier Sagredo <jasataco@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Build failed:

@jasagredo
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Merge conflict.

@nrdxp
Copy link

nrdxp commented Mar 3, 2023

Sorry to just pop in here, but I noticed you are using std already, so you might be able to benefit from std-action

jasagredo and others added 2 commits March 6, 2023 09:47
@jasagredo
Improve GHA situation
18174fc 
- Builds only with `ghc-9.2.5` on windows
- Builds only on non-draft PRs
- Inexpensive checks are aggregated into one workflow
@jasagredo
Run only one concurrent workflow on GHA
96aa434 
See https://docs.github.com/en/actions/using-jobs/using-concurrency
@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from fbf4e2e to f6d911e Compare March 6, 2023 08:48
@jasagredo jasagredo mentioned this pull request Mar 6, 2023
Closed
@jasagredo
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 6, 2023
@iohk-bors @jasagredo
Merge #4421
14c7fb5 
4421: Improve GHA situation r=Jasagredo a=Jasagredo

# Description

- Builds only with `ghc-9.2.5` on windows
- Builds only on non-draft PRs
- Doesn't build Consensus on GHA
- Inexpensive checks are aggregated into one workflow


Co-authored-by: Javier Sagredo <jasataco@gmail.com>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
@jasagredo
Copy link
Contributor Author

Sorry to just pop in here, but I noticed you are using std already, so you might be able to benefit from std-action

Hi Tim, thanks for the suggestion, but currently we don't (or at least I don't think we do!) use Nix in our GHA workflow. Please correct me otherwise, but I don't think we can leverage that action right now.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 6, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"3 of 8 required status checks are expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from f6d911e to c549a09 Compare March 6, 2023 11:33
@jasagredo
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 6, 2023
@iohk-bors @jasagredo
Merge #4421
db388cd 
4421: Improve GHA situation r=Jasagredo a=Jasagredo

# Description

- Builds only with `ghc-9.2.5` on windows
- Builds only on non-draft PRs
- Doesn't build Consensus on GHA
- Inexpensive checks are aggregated into one workflow


Co-authored-by: Javier Sagredo <jasataco@gmail.com>
Co-authored-by: Javier Sagredo <javier.sagredo@iohk.io>
@jasagredo
Copy link
Contributor Author

bors cancel

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 6, 2023

Canceled.

@jasagredo
Copy link
Contributor Author

bors r+

@jasagredo jasagredo force-pushed the jasagredo/dont-build-consensus-gha branch from c549a09 to 1eef179 Compare March 6, 2023 13:49
@jasagredo
Copy link
Contributor Author

bors cancel

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 6, 2023

Canceled.

@jasagredo
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 6, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit fe1527b into master Mar 6, 2023
@iohk-bors iohk-bors bot deleted the jasagredo/dont-build-consensus-gha branch March 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen left review comments

@coot coot coot approved these changes

@bolt12 bolt12 bolt12 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@nfrisby nfrisby Awaiting requested review from nfrisby

@dnadales dnadales Awaiting requested review from dnadales

@bartfrenk bartfrenk Awaiting requested review from bartfrenk

Assignees

@jasagredo jasagredo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasagredo @nrdxp @coot @amesgen @bolt12