Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store benchmark data #4422

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Store benchmark data #4422

merged 1 commit into from
Mar 6, 2023
+108 −29

Conversation

dnadales
Copy link
Member

@dnadales dnadales commented Mar 2, 2023

Turn the benchmark data into a JSON file that can be fed to https://github.com/benchmark-action/github-action-benchmark

Reduce the number of mempool benchmarks we run to 2.

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
    • Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers.
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@dnadales dnadales requested a review from nfrisby as a code owner March 2, 2023 12:50
@dnadales dnadales requested review from a user and bartfrenk and removed request for nfrisby and bartfrenk March 2, 2023 12:50
ghost
ghost approved these changes Mar 2, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would use proper CSV parsing in a later PR

ouroboros-consensus-test/bench-mempool/Main.hs Show resolved Hide resolved
ghost
ghost reviewed Mar 3, 2023
View reviewed changes
ouroboros-consensus-test/bench-mempool/Main.hs

-- Convert a number of picoseconds to the largest time unit that
-- makes the conversion greater or equal than one.
convertPicosecondsWithUnit :: Double -> (Double, String)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this conversion needed? To scale the benchmarks to the best unit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This is what Tasty.Benchmark seems to be doing as well.

@dnadales
Copy link
Member Author

dnadales commented Mar 3, 2023

bors r+

@dnadales
Copy link
Member Author

dnadales commented Mar 3, 2023

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 3, 2023

Merge conflict.

@dnadales dnadales force-pushed the dnadales/4413-store-benchmark-data branch 2 times, most recently from 9bfa060 to 6fc776f Compare March 6, 2023 13:13
@dnadales
Output the mempool benchmark results as JSON
499efa6 
... which conforms to the input expected by
https://github.com/benchmark-action/github-action-benchmark

This patch also reduces the number of mempool benchmarks: we do not need
that many data points for this benchmark. We should be austere in the
benchmarks we produce, since the reports can easily get cluttered, and
we will add more benchmarks in the future.
@dnadales dnadales force-pushed the dnadales/4413-store-benchmark-data branch from 6fc776f to 499efa6 Compare March 6, 2023 13:44
@dnadales
Copy link
Member Author

dnadales commented Mar 6, 2023

bors r+

@dnadales dnadales mentioned this pull request Mar 6, 2023
Merged
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 6, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 376baf1 into master Mar 6, 2023
@iohk-bors iohk-bors bot deleted the dnadales/4413-store-benchmark-data branch March 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dnadales