Fixed cddl spec for tx-submission protocol #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use `tx` rather than `txId` in the cddl. It only works because we use `int` for both.
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
from
acb6114
to
367755f
Compare
bolt12
approved these changes
Jun 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
from
8046456
to
d8eedfb
Compare
|
@bolt12 I changed this PR considerably, so please review it again. We should use this idea in other mini-protocols / specs as well. The only question is if we should modify data structure in |
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
from
d8eedfb
to
43586d7
Compare
bolt12
requested changes
Jun 13, 2023
ouroboros-network-protocols/testlib/Ouroboros/Network/Protocol/TxSubmission2/Test.hs
Outdated
Show resolved
Hide resolved
This was referenced Jun 13, 2023
|
I created the issue: #4595 |
bolt12
approved these changes
Jun 13, 2023
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
from
43586d7
to
2a00a1c
Compare
|
I had to also fix the |
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
2 times, most recently
from
4009b63
to
dcdd47a
Compare
`cddl` comes with `any` definition, it can be used to indicate that the data structures in our spec are not specified in `ouroboros-network`. This patch introduces `Any` type which can be used for the same reason on Haskell side. This patch only introduces it in `TxSubmission` and `LocalTxSubmission` mini-protocols, but we should do that for other mini-protocols too. In this patch we modified the definition of `Tx` and `TxId` used in `ouroboros-network-protocols:test` as well as `ouroboros-network-protocols:cddl` components.
These are already run in `ouroboros-network-framework:test`. Also fixed a typo.
coot
force-pushed
the
coot/fix-tx-submission-cddl
branch
from
dcdd47a
to
2b8ded6
Compare
oskin1
reviewed
Sep 15, 2023
| ; transactions (tx) are themselves, `ouroboros-network` is polymorphic over | ||
| ; them. | ||
| txId = any | ||
| tx = any |
There was a problem hiding this comment.
Where can I find specification of what is expected here by the actual cardano-node implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use
txrather thantxIdin the cddl. It only worksbecause we use
intfor both.