coot/ping 0.2.0.3 #4589
Merged
coot/ping 0.2.0.3 #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Jun 9, 2023
coot
commented
- handshake: make the code more readable
- cardano-ping: modify proposed versions when quering
- cardano-ping: printing of query result
- cardano-ping: v0.2.0.3
bolt12
approved these changes
Jun 9, 2023
When doing a query we send `InitiatorAndResponder` flag for versions smaller than `NodeToNodeVersionV11`. These versions of handshake do not support query, and always reply with handshake negotiation. If we send `IntiatorAndResponder` we will receive back the negotiated version and but the diffusion mode flag will be the original flag of the server. We risk that if the node is supporting `V10` that it will start using the connection as duplex one, but this shouldn't really matter as the ping client will anyway close the connection just after receiving handshake response.
Print query result as the last message, in case of negotiation error always print received versions from the remote host.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.