Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for safety: don't expose FileDescriptor constructor #4664

Merged

Conversation

mtullsen
Copy link
Contributor

@mtullsen mtullsen commented Sep 1, 2023

Description

resolves #3835

(the title says it all, one simple commit)

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot
Copy link
Contributor

coot commented Sep 7, 2023

Stylish haskell complains, you can run it locally with nix .\#stylish-haskell or directly with ./scripts/ci/check-stylish.sh (assuming you have fd and the right version of stylish-haskell installed).

@mtullsen mtullsen force-pushed the galois/issue-3835-no-expose-FileDescriptor branch from c8c4259 to 6b4d053 Compare September 17, 2023 07:52
@mtullsen mtullsen force-pushed the galois/issue-3835-no-expose-FileDescriptor branch from 6b4d053 to 92f7a6a Compare September 17, 2023 08:19
@coot coot added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 25, 2023
@coot coot added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 26, 2023
@coot coot added this pull request to the merge queue Sep 26, 2023
Merged via the queue into IntersectMBO:master with commit e94e354 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspect use of unsafe functions in network packages
2 participants